Add jyn514 and Manishearth to the rustdoc team#384
Merged
Mark-Simulacrum merged 3 commits intorust-lang:masterfrom Jul 17, 2020
Merged
Add jyn514 and Manishearth to the rustdoc team#384Mark-Simulacrum merged 3 commits intorust-lang:masterfrom
Mark-Simulacrum merged 3 commits intorust-lang:masterfrom
Conversation
Member
Oops, you probably need to update |
Contributor
|
👍 from me |
Member
|
I think we should also move the perf = true from @jyn514 to the rustdoc team as a whole, now that perf supports doc benchmarking it makes sense to integrate that I think. |
Member
Author
|
@Mark-Simulacrum Good idea! Should I open another PR for that? |
Member
|
Up to you. Happy to have it happen in this PR too (maybe as a separate commit). |
Member
Author
|
Done! |
Member
|
Okay I think we'll want approval from @ollie27 presumably and then this is good to go. |
Member
Author
|
Absolutely. :) |
|
Fine with me 👍 |
Member
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs.rs.I think they will both bring a lot more of new things into rustdoc.
Do you approve their integrations @rust-lang/rustdoc?