-
Notifications
You must be signed in to change notification settings - Fork 248
Deduplicate {linux_android,getrandom}.rs #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dda4534 to
b161b99
Compare
newpavlov
approved these changes
Feb 5, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you also remove lines 101-104 from the nopanic.yaml? Similar edits are also needed for the Clippy checks in workspace.yml.
The former is identical to the latter. Remove the former.
Contributor
Author
|
Done. |
b161b99 to
fa6c9d7
Compare
Merged
newpavlov
added a commit
that referenced
this pull request
Mar 17, 2025
### Added - `efi_rng` opt-in backend [#570] - `linux_raw` opt-in backend [#572] - `.cargo/config.toml` example in the crate-level docs [#591] - `getrandom_test_linux_without_fallback` configuration flag to test that file fallback is not triggered in the `linux_android_with_fallback` backend [#605] - Built-in support for `*-linux-none` targets [#618] - Cygwin support [#626] ### Changed - Update `wasi` dependency to v0.14 [#594] - Add `#[inline]` attribute to the inner functions [#596] - Update WASI and Emscripten links in the crate-level docs [#597] - Do not use `dlsym` on MUSL targets in the `linux_android_with_fallback` backend [#602] - Remove `linux_android.rs` and use `getrandom.rs` instead [#603] - Always use `RtlGenRandom` on Windows targets when compiling with pre-1.78 Rust [#610] - Internal representation of the `Error` type [#614] - Remove `windows-targets` dependency and use [`raw-dylib`] directly [#627] ### Removed - `Error::INTERNAL_START` and `Error::CUSTOM_START` associated constants [#614] [#570]: #570 [#572]: #572 [#591]: #591 [#594]: #594 [#596]: #596 [#597]: #597 [#602]: #602 [#603]: #603 [#605]: #605 [#610]: #610 [#614]: #614 [#618]: #618 [#626]: #626 [#627]: #627 [`raw-dylib`]: https://doc.rust-lang.org/reference/items/external-blocks.html?highlight=link#dylib-versus-raw-dylib
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
### Added - `efi_rng` opt-in backend [rust-random#570] - `linux_raw` opt-in backend [rust-random#572] - `.cargo/config.toml` example in the crate-level docs [rust-random#591] - `getrandom_test_linux_without_fallback` configuration flag to test that file fallback is not triggered in the `linux_android_with_fallback` backend [rust-random#605] - Built-in support for `*-linux-none` targets [rust-random#618] - Cygwin support [rust-random#626] ### Changed - Update `wasi` dependency to v0.14 [rust-random#594] - Add `#[inline]` attribute to the inner functions [rust-random#596] - Update WASI and Emscripten links in the crate-level docs [rust-random#597] - Do not use `dlsym` on MUSL targets in the `linux_android_with_fallback` backend [rust-random#602] - Remove `linux_android.rs` and use `getrandom.rs` instead [rust-random#603] - Always use `RtlGenRandom` on Windows targets when compiling with pre-1.78 Rust [rust-random#610] - Internal representation of the `Error` type [rust-random#614] - Remove `windows-targets` dependency and use [`raw-dylib`] directly [rust-random#627] ### Removed - `Error::INTERNAL_START` and `Error::CUSTOM_START` associated constants [rust-random#614] [rust-random#570]: rust-random#570 [rust-random#572]: rust-random#572 [rust-random#591]: rust-random#591 [rust-random#594]: rust-random#594 [rust-random#596]: rust-random#596 [rust-random#597]: rust-random#597 [rust-random#602]: rust-random#602 [rust-random#603]: rust-random#603 [rust-random#605]: rust-random#605 [rust-random#610]: rust-random#610 [rust-random#614]: rust-random#614 [rust-random#618]: rust-random#618 [rust-random#626]: rust-random#626 [rust-random#627]: rust-random#627 [`raw-dylib`]: https://doc.rust-lang.org/reference/items/external-blocks.html?highlight=link#dylib-versus-raw-dylib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is identical to the latter. Remove the former.
r? newpavlov