Conversation
16 tasks
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
malloc_size_of_v2
branch
from
4e4bfb7 to
a41a489
Compare
Contributor
Author
|
Not sure why this is failing CI it's complaining about |
mbrubeck
approved these changes
Feb 16, 2025
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
Author
|
Turns out this was failing due to using Cargo features ( |
mbrubeck
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that malloc_size_of is published to crates.io we are moving the trait implementations of MallocSizeOf and related traits into the crates that define the types. This will avoid the situation where depending on
malloc_size_ofpulls in a large number of dependencies.This PR adds the implementation of
MallocSizeOfto the 2.x version of thesmallveccrate.