[5.x] Auto stache watcher setting #10354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service provider screws up tests
jasonvarga
requested review from
a team,
jackmcdade and
jesseleite
and removed request for
jackmcdade and
jesseleite
# Conflicts: # tests/Stache/StacheTest.php
# Conflicts: # src/Console/Commands/SupportDetails.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an "automatic" Stache Watcher setting.
We've received multiple requests to disable the Stache watcher by default so that it doesn't accidentally get enabled on production.
But we can't do that otherwise during development users would be confused why their file edits are not being reflected in their site.
Rather than just a boolean for turning the watcher on or off, this PR adds an
'auto'setting that would be enabled when the environment islocaland disabled for any other environment. We would make this the new default setting.There would be no change for existing sites as they'd likely have either/both
watcherinstache.phporSTATAMIC_STACHE_WATCHERin.env.statamic/ideas#1178