Add containers for building and testing SU2 with the thread sanitizer#17
Merged
Add containers for building and testing SU2 with the thread sanitizer#17
Conversation
jblueh
commented
Jun 22, 2023
pcarruscag
approved these changes
Jun 23, 2023
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Do you want to add this to the actions https://github.com/su2code/Docker-Builds/blob/master/.github/workflows/docker-image-upload.yml
So that we know whether it builds and uploads fine? Then it would be easy to use in our tests.
Collaborator
Author
Yes, I will add it. |
Collaborator
Author
|
Should I go ahead and merge to trigger the pipeline? |
Member
|
Yeah go for it |
This was referenced Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR provides a container that can be used for building SU2 with the thread sanitizer. Further steps would be a container for testing with the thread sanitizer, and ultimately running thread sanitizer tests as a part of SU2's CI pipeline. This is work in progress and there are things that need testing, hence the focus on the build container for now.
gccfrom source, which does take some time.