Conversation
Member
Author
|
Last week folks mentioned, during the meeting, that this would be helpful, so I'll take it as approved. |
Contributor
TobiKattmann
left a comment
TobiKattmann
left a comment
There was a problem hiding this comment.
💐 Thanks, also for the little stuff around
| return false || force_writing; | ||
| } | ||
|
|
||
| void CFlowOutput::AddCommonFVMOutputs(const CConfig *config) { |
Contributor
There was a problem hiding this comment.
👍 Special reason to not move COORD-XYZ here?
Member
Author
There was a problem hiding this comment.
Order matters I think.
Contributor
There was a problem hiding this comment.
yep it does (tried it out) ... it needs to be the first, at least for paraview output
TobiKattmann
added a commit
that referenced
this pull request
Apr 28, 2021
TobiKattmann
added a commit
that referenced
this pull request
Apr 28, 2021
This reverts commit e28e7bb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
New output to visualize the coarse grids.
It is based on coloring nodes, which is a little difficult to visualize with Paraview since it interpolates to elements, anyway:
PR Checklist