Skip to content

More NEMO cleanup#1391

Merged
jtneedels merged 1 commit intodevelopfrom
NEMO_cleanup
Oct 5, 2021
Merged

More NEMO cleanup#1391
jtneedels merged 1 commit intodevelopfrom
NEMO_cleanup

Conversation

@jtneedels
Copy link
Contributor

@jtneedels jtneedels commented Oct 4, 2021

Proposed Changes

  • Adding newline to some files, removing extraneous newlines

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels jtneedels changed the title standardizing 1 newline spacing at end of files More NEMO cleanup Oct 4, 2021
@jtneedels jtneedels requested a review from WallyMaier October 4, 2021 20:41
@WallyMaier
Copy link
Contributor

@jtneedels Im a bit confused why this is necessary? Why do files need extra lines? versus not?

@jtneedels
Copy link
Contributor Author

@jtneedels Im a bit confused why this is necessary? Why do files need extra lines? versus not?

Github flags it as an issue, I think the main concern is it can cause problems when files are concatenated. Basically just a "better safe than sorry" situation.

@TobiKattmann
Copy link
Contributor

Hi @jtneedels thanks for following up on that after-merge-review of #1389 . From my point of view it would have been enough to sneak those into another PR but this doesn't hurt either :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants