Fixed an error for the Coupled RHT-CFD Adjoint test in serial_regression_AD.py#1437
Merged
pcarruscag merged 1 commit intosu2code:developfrom Nov 13, 2021
Conversation
…Coupled RHT-CFD Adjoint test in serial_regression_AD.py.
This was referenced Nov 12, 2021
TobiKattmann
approved these changes
Nov 12, 2021
Contributor
TobiKattmann
left a comment
There was a problem hiding this comment.
💐 thanks Thomas.
As far as I see, there is a discrepancy for one DV only in that very Testcase, and that is in the last displayed digit (-0.00432385 vs -0.00432384) which I think is ok to just change. So please go ahead and change that. Once serial_regression_AD passes this can be merged from my perspective
Contributor
Author
|
Yes there is a discrepancy in the last digit for one the gradient values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Coupled RHT-CFD Adjoint did not compare the computed gradient file to the reference file. Instead, the test case passed without file comparison.
Proposed Changes
Added a call to run_filediff to ensure the test is run.
Moved the Coupled RHT-CFD Adjoint test in serial_regression_AD.py down to the file difference test.
Related Work
This fixes the related issue #1431
The reference gradient file in the test case repo needs a small modification. See su2code/TestCases/pull/84
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.