fix mistake in axisymmetric turbulent source production term#1438
Merged
pcarruscag merged 3 commits intodevelopfrom Nov 13, 2021
Merged
fix mistake in axisymmetric turbulent source production term#1438pcarruscag merged 3 commits intodevelopfrom
pcarruscag merged 3 commits intodevelopfrom
Conversation
Member
Author
|
restart file update su2code/TestCases#85 |
pcarruscag
approved these changes
Nov 13, 2021
pcarruscag
reviewed
Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small mistake I discovered in code that I added with #1195 (I just learned the hard way that it is better to use common/general forms of equations instead of trying to simplify/factorise them as much as possible).
In case anyone wants to verify, the sources used are in #1195, the terms are found by subtracting the cartesian formulation from the cylindrical one and here is the simplification/factorisation bit:
Sorry!