Skip to content

Fix some "resource not released in destructor" warnings#1579

Merged
pcarruscag merged 5 commits intodevelopfrom
fix_resource_not_released_in_dtor
Mar 27, 2022
Merged

Fix some "resource not released in destructor" warnings#1579
pcarruscag merged 5 commits intodevelopfrom
fix_resource_not_released_in_dtor

Conversation

@pcarruscag
Copy link
Member

The COption classes should delete what they allocate

@lgtm-com
Copy link

lgtm-com bot commented Mar 26, 2022

This pull request fixes 3 alerts when merging 6dfceaa into cd4ecca - view on LGTM.com

fixed alerts:

  • 3 for Resource not released in destructor

Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking into that structure and fixing and cleaning this 💐 I have no further comments

option_structure.inl` is not exactly my favorite file and tedious to understand what's really going on imo, so extra 👍 for doing that 🙇

@lgtm-com
Copy link

lgtm-com bot commented Mar 26, 2022

This pull request fixes 7 alerts when merging 8772194 into cd4ecca - view on LGTM.com

fixed alerts:

  • 7 for Resource not released in destructor

@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2022

This pull request fixes 8 alerts when merging 2082383 into cd4ecca - view on LGTM.com

fixed alerts:

  • 8 for Resource not released in destructor

@pcarruscag pcarruscag merged commit 3f3cb55 into develop Mar 27, 2022
@pcarruscag pcarruscag deleted the fix_resource_not_released_in_dtor branch March 27, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants