Skip to content

Fix reference pressure for Cp with moving frames (e.g. ROTATING_FRAME)#1595

Merged
pcarruscag merged 4 commits intodevelopfrom
fix_1588
Apr 11, 2022
Merged

Fix reference pressure for Cp with moving frames (e.g. ROTATING_FRAME)#1595
pcarruscag merged 4 commits intodevelopfrom
fix_1588

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Apr 6, 2022

Fixes #1588
cc @ArneVoss
I have not fully tested the python wrapper forces, but they should be ok for dimensional simulations.
This is WIP until I add a regression test.

@pcarruscag pcarruscag changed the title [WIP] Fix reference pressure for Cp with moving frames (e.g. ROTATING_FRAME) Fix reference pressure for Cp with moving frames (e.g. ROTATING_FRAME) Apr 9, 2022
@pcarruscag
Copy link
Member Author

python forces are also ok for non-dimensional simulations

@ArneVoss
Copy link
Member

Pedro,
I cherry-picked your your commit c2018c8 and tested it with my configuration. Looks good so far, I haven't see any issues / problems on my side. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants