Fix #1667 Potential crash for the OpenMP multi-thread running.#1678
Merged
pcarruscag merged 2 commits intosu2code:developfrom Jul 22, 2022
Merged
Fix #1667 Potential crash for the OpenMP multi-thread running.#1678pcarruscag merged 2 commits intosu2code:developfrom
pcarruscag merged 2 commits intosu2code:developfrom
Conversation
Initialize the omp_partitions vector with the number of points, skip the for loop if the last partition has been calculated. A light-weight checker is added to verify the validation of the partition vector.
pcarruscag
approved these changes
Jun 21, 2022
Member
|
Thank you for opening a PR, please add yourself to AUTHORS.md (note that it is in a funny alphabetical order with upper case before lower case) |
Contributor
Author
|
Thanks for the approval. I will update the AUTHORS.md next time together with other changes. |
WallyMaier
approved these changes
Jun 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Initialize the omp_partitions vector with the number of points, skip the for loop if the last partition has been calculated. A light-weight checker is added also to verify the partition vector, promote a warning or error message if necessary.
Related Work
Fix #1667 Potential crash for the OpenMP multi-thread running.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.