Skip to content

Source term for axisymmetry in species transport#1785

Merged
bigfooted merged 33 commits intosu2code:developfrom
lkusch:feature_axisymmetry_species
Oct 12, 2022
Merged

Source term for axisymmetry in species transport#1785
bigfooted merged 33 commits intosu2code:developfrom
lkusch:feature_axisymmetry_species

Conversation

@lkusch
Copy link
Contributor

@lkusch lkusch commented Oct 7, 2022

Proposed Changes

This adds the source term for axisymmetry to the residual computation for species transport. The source term is zero for non-axisymmetric cases.

Related Work

This builds upon the closed pull request #1762 and is connected to #card-71271518 as an aspect of feature_flamelet.
The change uses the implementation by @bigfooted on feature_flamelet. The implemented source term was checked against literature/own derivation by @Cristopher-Morales.
I would like to set up a regression test as soon as #1784 is merged.

PR Checklist

  • [x ] I am submitting my contribution to the develop branch.
  • [x ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [x ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag changed the title Source term for axisymmetry in species transport [WIP] Source term for axisymmetry in species transport Oct 7, 2022
@pr-triage pr-triage bot removed the PR: unreviewed label Oct 7, 2022
lkusch and others added 12 commits October 10, 2022 11:36
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: Nijso <nijso@hotmail.com>
lkusch and others added 8 commits October 10, 2022 17:26
@bigfooted
Copy link
Contributor

@lkusch if it's good to go, please remove WIP from the title.

@lkusch lkusch changed the title [WIP] Source term for axisymmetry in species transport Source term for axisymmetry in species transport Oct 11, 2022
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but it would be good to use in a regression at some point.
It would be good to have start having some more formal V&V for species transport @bigfooted @Cristopher-Morales

@bigfooted
Copy link
Contributor

This LGTM but it would be good to use in a regression at some point. It would be good to have start having some more formal V&V for species transport @bigfooted @Cristopher-Morales

Good, we'll add these V&V, the results from my first attempt after a 2 week su2 crash course with Tom: https://su2code.github.io/documents/dev_meeting_2018/03_su2_dev_beishuizen.pdf

@bigfooted bigfooted merged commit c3c6649 into su2code:develop Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants