Conversation
Contributor
Author
|
@danielmayer I've created a separate PR for the changes that you've made in the existing LUT files. Maybe we can replace these lines with a function: [EDIT] I replaced it. |
bigfooted
commented
Oct 16, 2022
pcarruscag
reviewed
Oct 16, 2022
pcarruscag
reviewed
Oct 16, 2022
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
pcarruscag
reviewed
Oct 16, 2022
Fix quantity names in table constructor for reg. test.
pcarruscag
reviewed
Oct 19, 2022
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
pcarruscag
reviewed
Oct 19, 2022
Comment on lines
278
to
280
| /*! \brief Extracts characters from file_stream, removes trailing control characters, | ||
| * and stores them into line. | ||
| */ |
Member
There was a problem hiding this comment.
Btw it is usually better to put the doxygen comment on the declaration hpp, but it's fine
Contributor
Author
There was a problem hiding this comment.
Thanks, I've moved it to the hpp files. When it goes through the regression tests, I'll merge.
pcarruscag
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
This is a small update of the lookup table routines to prepare for the implementation of the flamelet model. A bug was fixed and the header file definition changed (keywords in sentences are capitalized). Some small textual changes were made.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
related to the upcoming PR for feature_new_flamelet
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.