Implementation of LM model for SA and cross-flow corrections (LM2015)#1810

rois1995 · 2022-11-08T15:40:10Z

Proposed Changes

This branch implements the Langtry Menter transition model coupled to SA turbulence model (https://turbmodels.larc.nasa.gov/sa_gamma_retheta_3eqn.html). It also includes the transition induced by crossflow effects through the LM2015 implementation (https://turbmodels.larc.nasa.gov/langtrymenter_4eqn.html). The config options added are:

KIND_TRANS_CORRELATION. It allows the selection among correlation models found in the literature for F_length and ReTheta_c variables. Values are MALAN, SULUKSNA, KRAUSE, MEDIDA_BAEDER, MEDIDA, MENTER_LANGTRY. It defaults to the MENTER_LANGTRY If the underlying turbulence model is SST or to MALAN in the case of SA. (Implemented)
HROUGHNESS. RMS value of roughness for LM2015 transition model. It defaults to 1e-6m. (Implemented)
CONVERTSA2SST. If the SA turbulence model is used, it is possible to use the LM version for SST by computing k and w from SA variables. Values: YES, NO. The default is NO. (Not yet Implemented)

The turbulence index has been implemented for the turbulence models. It is used to detect transition when it is higher than 0. In theory, it should be equal to 1 for a fully-turbulent flow. However, in my simulations, this is not always the case, especially if SST is used (you can see in on the figure below). References are https://doi.org/10.1007/s10494-021-00288-5 for SST and https://doi.org/10.2514/6.1992-439 for SA.

Validation test cases will be uploaded in the following days.

The most important results can be found in the pdf of my presentation at the SU2 Conference 2022. https://polimi365-my.sharepoint.com/:b:/g/personal/10507725_polimi_it/EUswl9Jw0XhIuozrOjXqX6sBdscM30lRZ7mwMZcr5anvyA?e=41db5P

One recent result is the application of the transition model to the Sickle wing test case for -2.67° of the angle of attack.

SST+LM2015

SA+LM2015

The lower surface is represented on the left, whereas the upper surface is on the right. At the moment the wind tunnel walls have not been taken into account. This can explain the spanwise shift of the transition with respect to the experimental results. More results are incoming.

Please, any suggestions on how to clean up the code or on how to make it more efficient are very well accepted.

Related Work

Work is related to the PR #1751. It extends it to SA turbulence model and includes cross-flow effects (LM2015) and turbulence index computations.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

- Added cross-flow corrections through LM2015 model - Added correlation functions - Fixed some output bugs

bigfooted · 2022-11-08T20:10:47Z

Nice work already! If you click on 'Details' at the right of the failed Regression and Unit Testing cases you will see why they fail. I think one of the first things to do is go through these error messages ('variable may be used uninitialized', etc) and fix them so the regression tests will run.

rois1995 · 2022-11-09T11:49:07Z

Nice work already! If you click on 'Details' at the right of the failed Regression and Unit Testing cases you will see why they fail. I think one of the first things to do is go through these error messages ('variable may be used uninitialized', etc) and fix them so the regression tests will run.

Thank you! I am in the middle of doing it. Hopefully, there are not that many issues.

Common/include/option_structure.hpp

Common/src/CConfig.cpp

SU2_CFD/include/numerics/CNumerics.hpp

SU2_CFD/include/numerics/turbulent/transition/trans_sources.hpp

- Moved default correlation function to CConfig post processing - Added correct (?) Krause correlation functions as KRAUSE_HYPER

rois1995 · 2022-11-11T13:48:50Z

At the moment I am having trouble with a test case, thus it is still not ready to merge. I'll try to fix it as soon as possible.

SU2_CFD/include/numerics/CNumerics.hpp

SU2_CFD/include/numerics/turbulent/transition/trans_sources.hpp

Common/include/option_structure.hpp

SU2_CFD/src/drivers/CDriver.cpp

SU2_CFD/src/solvers/CTurbSASolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

SU2_CFD/src/variables/CTurbVariable.cpp

pcarruscag · 2022-11-15T19:12:05Z

Oh, and please consider adding a contribution to the V&V page (to also add a regression test for the new model).

- Fixed Jacobian computation for LM2015 - Code refactoring

pcarruscag

The lm options look good 👍

SU2_CFD/src/solvers/CTransLMSolver.cpp

SU2_CFD/src/solvers/CTurbSASolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

SU2_CFD/include/variables/CVariable.hpp

SU2_CFD/src/output/CFlowOutput.cpp

pcarruscag

Thank you for the changes, this PR LGTM after you move the correlations to a common place and add a regression test.

Common/include/option_structure.hpp

Common/src/CConfig.cpp

SU2_CFD/src/output/CFlowOutput.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

SU2_CFD/src/solvers/CTurbSASolver.cpp

Common/include/option_structure.hpp

Common/src/CConfig.cpp

SU2_CFD/include/numerics/turbulent/transition/trans_correlations.hpp

SU2_CFD/include/numerics/turbulent/transition/trans_sources.hpp

SU2_CFD/include/variables/CVariable.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…ns.hpp Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

TestCases/transition/Prolate_Spheroid/transitional_SA_LM_model_ConfigFile.cfg

TestCases/transition/E387_Airfoil/transitional_SST_LM_model_ConfigFile.cfg

…into feature_LM2015_model

.github/workflows/regression.yml

pcarruscag · 2022-12-18T01:03:38Z

.github/workflows/regression.yml

        with:
          # -t <Tutorials-branch> -c <Testcases-branch>
-          args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}
+          args: -b ${{github.ref}} -t feature_LM2015 -c develop -s ${{matrix.testscript}}


Suggested change

args: -b ${{github.ref}} -t feature_LM2015 -c develop -s ${{matrix.testscript}}

args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}

Cc @patelha57

pcarruscag

LGTM

…into feature_LM2015_model

rois1995 added 2 commits November 7, 2022 10:08

- Added LM transition model for SA turbulence model

237fdfb

- Added cross-flow corrections through LM2015 model - Added correlation functions - Fixed some output bugs

- Fixed Rt computation in Post processing

da348c5

pr-triage bot added the PR: unreviewed label Nov 8, 2022

rois1995 changed the title ~~Feature lm2015 model~~ Implementation of LM model for SA and cross-flow corrections (LM2015) Nov 8, 2022

rois1995 added 3 commits November 8, 2022 19:38

- Fixed DEFAULT values of transition correlation

cab0dd9

- Fix NONE switch for turbulence model

1ee1958

- Fixed DEFAULT transition correlation

e2312f5

pcarruscag mentioned this pull request Nov 8, 2022

[WIP] Implementation of transition LM model (LM2009, LM2015) for SA and SST #1788

Closed

5 tasks

- Fix non.initialized variables Pt. 1

4927df7

rois1995 added 4 commits November 9, 2022 13:01

- Fix reorder warning

3360b5d

- Fix reorder warning Pt. 2

79c0e98

- Fix SST blending function for LM2015

bcffab9

- Fix some transition 'if' clauses

3b10934

pcarruscag reviewed Nov 9, 2022

View reviewed changes

- Fix restart for multigrid

329344b

- Moved default correlation function to CConfig post processing - Added correct (?) Krause correlation functions as KRAUSE_HYPER

pcarruscag reviewed Nov 15, 2022

View reviewed changes

rois1995 and others added 4 commits November 18, 2022 15:27

- Fix Jacobian computation for transition with LM2015 model

b2e9151

- Added LM_OPTIONS

36cf4b8

- Fixed Jacobian computation for LM2015 - Code refactoring

Merge branch 'develop' into feature_LM2015_model

19f493a

- Fix turbulence index computation

ab65142

pcarruscag reviewed Nov 24, 2022

View reviewed changes

- Sintax changes

4d8065c

pcarruscag reviewed Nov 25, 2022

View reviewed changes

Apply suggestions from code review

d099f39

pcarruscag added the changelog:feature label Nov 25, 2022

pcarruscag reviewed Nov 25, 2022

View reviewed changes

Common/include/option_structure.hpp Show resolved Hide resolved

pcarruscag reviewed Dec 8, 2022

View reviewed changes

rois1995 and others added 9 commits December 9, 2022 18:15

Update Common/include/option_structure.hpp

a8efdc4

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/option_structure.hpp

f9eff62

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/option_structure.hpp

055f27a

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/src/CConfig.cpp

89d1fed

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/transition/trans_correlatio…

fbb907e

…ns.hpp Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/transition/trans_sources.hpp

9664f2a

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/variables/CVariable.hpp

0e7e9f9

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

- Remove unecessary comments from config files

ae9a018

Merge branch 'develop' into feature_LM2015_model

14dc543

pcarruscag reviewed Dec 9, 2022

View reviewed changes

TestCases/transition/Prolate_Spheroid/transitional_SA_LM_model_ConfigFile.cfg Outdated Show resolved Hide resolved

TestCases/transition/E387_Airfoil/transitional_SST_LM_model_ConfigFile.cfg Outdated Show resolved Hide resolved

rois1995 and others added 4 commits December 11, 2022 17:03

Solving Compilation errors

b0ce516

Merge branch 'feature_LM2015_model' of https://github.com/su2code/SU2 …

fa412f8

…into feature_LM2015_model

- Add regression test case

e881a6c

move cases to tutorials

7b37288

pcarruscag reviewed Dec 18, 2022

View reviewed changes

.github/workflows/regression.yml Outdated Show resolved Hide resolved

pcarruscag reviewed Dec 18, 2022

View reviewed changes

pcarruscag added 2 commits December 17, 2022 17:03

Update .github/workflows/regression.yml

3e82114

Merge branch 'develop' into feature_LM2015_model

b5b8f41

pcarruscag approved these changes Dec 18, 2022

View reviewed changes

rois1995 added 4 commits December 18, 2022 12:14

- Modified regression workflow

df81b0b

Merge branch 'feature_LM2015_model' of https://github.com/su2code/SU2 …

ced7ed2

…into feature_LM2015_model

- Using correct branch

1407286

- Back to develop

66a7d5e

pcarruscag merged commit 4e0dfb8 into develop Dec 19, 2022

pcarruscag deleted the feature_LM2015_model branch December 19, 2022 17:25

pr-triage bot added PR: merged PR: unreviewed and removed PR: unreviewed PR: merged labels Dec 19, 2022

	args: -b ${{github.ref}} -t feature_LM2015 -c develop -s ${{matrix.testscript}}
	args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}

Conversation

rois1995 commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Related Work

PR Checklist

Uh oh!

bigfooted commented Nov 8, 2022

Uh oh!

rois1995 commented Nov 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rois1995 commented Nov 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag commented Nov 15, 2022

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag Dec 18, 2022

Choose a reason for hiding this comment

Uh oh!

pcarruscag Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rois1995 commented Nov 8, 2022 •

edited

Loading