Cleanup Linelets and create output to visualize them#1856
Merged
pcarruscag merged 13 commits intodevelopfrom Dec 29, 2022
Merged
Cleanup Linelets and create output to visualize them#1856pcarruscag merged 13 commits intodevelopfrom
pcarruscag merged 13 commits intodevelopfrom
Conversation
pcarruscag
changed the title
pcarruscag
commented
Dec 25, 2022
WallyMaier
reviewed
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing with variants of this preconditioner (Linelet - GS, Linelet - LU-SGS), they don't seem to be any better than LU-SGS or ILU, or even Linelet - Jacobi 🤷 so I kept the Linelet - Jacobi we had but with cleaner implementation.