Merged
Conversation
WallyMaier
reviewed
Feb 19, 2023
kursatyurt
reviewed
Feb 19, 2023
Co-authored-by: Wally Maier <wallytmaier@gmail.com>
… into update_config_template
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
… into update_config_template
Contributor
Author
|
I have added all existing config options to the config_template file. I do not know what these options do in many cases, but at least they are all visible to the users without immediately diving into the code. For some options, I do not know in which category they belong, so if you see some options that are misplaced, let me know. |
pcarruscag
reviewed
Apr 10, 2023
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
pcarruscag
reviewed
May 7, 2023
bigfooted
force-pushed
the
update_config_template
branch
from
ebcc512 to
80193b6
Compare
Contributor
Author
|
@pcarruscag is anything else needed for this PR? |
pcarruscag
reviewed
Sep 25, 2023
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Contributor
Author
|
@pcarruscag everything's been addressed, I think. |
pcarruscag
reviewed
Nov 17, 2023
pcarruscag
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I am going through the CConfig.cpp file and adding all the options to config_template.cfg that are not there yet.
I have found some options that do not seem to be used in the code, I will remove them.
There are probably also options in config_template.cfg that do not exist anymore, I will remove them as well.
Related Work
PR Checklist