Rename python Driver method 'Postprocessing' to 'Finalize'#1976
Merged
pcarruscag merged 2 commits intosu2code:developfrom Mar 21, 2023
kursatyurt:rename_postprocessing
Merged
Rename python Driver method 'Postprocessing' to 'Finalize'#1976pcarruscag merged 2 commits intosu2code:developfrom kursatyurt:rename_postprocessing
pcarruscag merged 2 commits intosu2code:developfrom
kursatyurt:rename_postprocessing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The driver method
Postprocessing()actually frees all the containers and finalizes the driver. As it does not reflect what is actually done and is easy to confuse with the methodPostprocess(), the PR proposes renaming the method toFinalize().PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.