Skip to content

Fix order of transition volume outputs#1985

Merged
pcarruscag merged 1 commit intodevelopfrom
fix_transition_outputs
Mar 26, 2023
Merged

Fix order of transition volume outputs#1985
pcarruscag merged 1 commit intodevelopfrom
fix_transition_outputs

Conversation

@pcarruscag
Copy link
Member

Keeping the solution group together to avoid issues in restarts

@bigfooted
Copy link
Contributor

Thanks for this, that is a nice clean up. But why not split ..Misc() into ..Limiter() and ..Primitive() ? In any case LGTM.

Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pcarruscag
Copy link
Member Author

The important group to keep together is the solution the rest doesn't really matter.
We should change the restart functions to look for variable names instead of relying on the assumed position.

@pcarruscag pcarruscag merged commit bf16c20 into develop Mar 26, 2023
@pcarruscag pcarruscag deleted the fix_transition_outputs branch March 26, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants