Allow selecting the zone used by the python wrapper (for multizone drivers)#2019
Merged
pcarruscag merged 8 commits intosu2code:developfrom Aug 13, 2023
Merged
Allow selecting the zone used by the python wrapper (for multizone drivers)#2019pcarruscag merged 8 commits intosu2code:developfrom
pcarruscag merged 8 commits intosu2code:developfrom
Conversation
pcarruscag
reviewed
Apr 29, 2023
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks for taking the lead on this, you changed too many places, only the functions of the python wrapper (the ones in the pySU2 group) need to be changed.
The others are internal functions of the drivers that need to work on the zone the driver decides.
Member
|
@afshawnlotfi is this working as expected? |
pcarruscag
approved these changes
May 15, 2023
Contributor
Author
Sorry this last week has been busy, will verify by the end of this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added
SelectZonefunction toCDriverBasethat dynamically sets the zone indexExample Usage
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.