Skip to content

CoolProp enhancement#2021

Merged
PENGYAN777 merged 4 commits intosu2code:developfrom
PENGYAN777:feature_coolprop
May 3, 2023
Merged

CoolProp enhancement#2021
PENGYAN777 merged 4 commits intosu2code:developfrom
PENGYAN777:feature_coolprop

Conversation

@PENGYAN777
Copy link
Contributor

Proposed Changes

Enhance CoolProp model by:

  1. add checkTemperature function to avoid critical temperature.
  2. impose gas phase by shifting temperature slightly.

Related Work

This work is an extension of PR #1947

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@PENGYAN777 PENGYAN777 merged commit 8b95cd7 into su2code:develop May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants