Add word-by-word comparison with tolerance and threshold to file diff.#2031
Merged
danielmayer merged 4 commits intodevelopfrom May 15, 2023
Merged
Add word-by-word comparison with tolerance and threshold to file diff.#2031danielmayer merged 4 commits intodevelopfrom
danielmayer merged 4 commits intodevelopfrom
Conversation
pcarruscag
approved these changes
May 13, 2023
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Thank you Daniel, LGTM after taking care of any CodeQL warnings
… into feature_tolerance_for_file_diff
bigfooted
approved these changes
May 15, 2023
Contributor
bigfooted
left a comment
There was a problem hiding this comment.
Thanks, Daniel, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current file comparison that is used for regression tests, does not feature a possibility to specify a tolerance or a threshold. This PR implements such a feature and does not affect the existing regression tests.
Related Work
Currently, there are no regression tests that make use of this feature and the PR does not include a new test that would use it. However, the feature_new_flamelet branch already uses this feature. This branch here is to split off the feature as it is not related to flamelet models but it is a general feature that can used for a variety of regression tests that use a file comparison.
PR Checklist