Skip to content

CoDiPack Update and Explicit Adjoints Locking#2146

Merged
jblueh merged 6 commits intodevelopfrom
ad_updates
Oct 13, 2023
Merged

CoDiPack Update and Explicit Adjoints Locking#2146
jblueh merged 6 commits intodevelopfrom
ad_updates

Conversation

@jblueh
Copy link
Contributor

@jblueh jblueh commented Oct 10, 2023

Proposed Changes

  • The CoDiPack update fixes a rare data race.
  • For consistency, the explicit adjoints resizing introduced previously is complemented by explicit adjoints locking.

Related Work

#2039

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh merged commit 9416b42 into develop Oct 13, 2023
@jblueh jblueh deleted the ad_updates branch October 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants