Feature CFL adaptation initial iteration#2362
Merged
bigfooted merged 9 commits intosu2code:developfrom Oct 25, 2024
Merged
Conversation
A spark initialization was not possible with CFL adaptation, as the CFL number would increase too far before the spark initiates the combustion. This led to immediate flashback or blow-off. An additional parameter in the CFL adaptation defines the iteration, at which the CFL adaption should start. This allows the combustion to stabilize before the CFL number increases.
pcarruscag
reviewed
Oct 9, 2024
bigfooted
reviewed
Oct 9, 2024
Choose Iteration based on multizone problem or singlezone problem Co-authored-by: Nijso <nijso@hotmail.com>
…zone/singlezone problem
Contributor
There was a problem hiding this comment.
Generally lgtm, is there maybe an existing testcase where you can reflect this(?)
Also, please grep the cfg files and add a 1 (or 0, I guess it does not matter because this would kick in only in the 2nd iteration anyway 🤔 ) to the CFL_ADAPT_PARAM field
fwiw: I started the CI pipeline
Member
|
Don't modify the configs to add default options. Just the template is enough |
bigfooted
reviewed
Oct 10, 2024
Co-authored-by: Nijso <nijso@hotmail.com>
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
Change initial iteration to 0 to match with default values
Contributor
In that case I think we're done? |
pcarruscag
approved these changes
Oct 25, 2024
Contributor
|
Thanks, Pedro! |
raghava-davuluri
pushed a commit
to hypersonic-lab/SU2
that referenced
this pull request
Sep 12, 2025
* Feature to define initial iteration to apply CFL adaption. A spark initialization was not possible with CFL adaptation, as the CFL number would increase too far before the spark initiates the combustion. This led to immediate flashback or blow-off. An additional parameter in the CFL adaptation defines the iteration, at which the CFL adaption should start. This allows the combustion to stabilize before the CFL number increases. Co-authored-by: Nijso <nijso@hotmail.com> Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com> Co-authored-by: Nijso <bigfootedrockmidget@hotmail.com> Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A spark initialization was not possible with CFL adaptation, as the CFL number would increase too far before the spark initiates the combustion. This led to immediate flashback or blow-off. An additional parameter in the CFL adaptation defines the iteration, at which the CFL adaption should start. This allows the combustion to stabilize before the CFL number increases. Before the initial iterations has not started, the CFL number does not get adapted in either direction.