Add thermal expansion effects to FEA solver#2399
Merged
pcarruscag merged 5 commits intodevelopfrom Dec 24, 2024
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * \brief Shape function Jacobian (dNi) evaluated at point Xi,Eta. | ||
| */ | ||
| inline static void ShapeFunctionJacobian(su2double Xi, su2double Eta, su2double dNi[][2]) { | ||
| inline static void ShapeFunctionJacobian(const su2double& Xi, const su2double& Eta, su2double dNi[][2]) { |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
| "of entries (the number of materials).", CURRENT_FUNCTION); | ||
| if (nMaterialThermalExpansion == 0) { | ||
| nMaterialThermalExpansion = 1; | ||
| MaterialThermalExpansion = new su2double[1](); |
Check warning
Code scanning / CodeQL
Resource not released in destructor Warning
Member
Author
There was a problem hiding this comment.
COption deletes it its destructor
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixed delta T based on freestream temperature and material reference temperature for now.
Thermal expansion coefficient can have one value per material (same as E, nu, and rho).
PR Checklist
pre-commit run --allto format old commits.