Update regression tests for tutorials#2423
Merged
pcarruscag merged 25 commits intodevelopfrom Feb 2, 2025
Merged
Conversation
pcarruscag
reviewed
Jan 19, 2025
Member
pcarruscag
left a comment
There was a problem hiding this comment.
What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2.
I guess we need to add FADO to the SU2 installation?
Contributor
Author
Yes, I am using FADO. Can you help in making FADO available during regression testing? |
Member
|
I'll try to do it tonight. |
Member
|
It's done, I have to update the init.py script but I'll do that after I check that the FADO examples work with the current version of SU2. |
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
pcarruscag
approved these changes
Jan 29, 2025
pcarruscag
reviewed
Feb 1, 2025
pcarruscag
reviewed
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add regression test for 90 degree bend adjoint design tutorial
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.