Fix preaccumulation error, improve recording of RANS solvers#2472
Merged
oleburghardt merged 9 commits intodevelopfrom Apr 15, 2025
Merged
Fix preaccumulation error, improve recording of RANS solvers#2472oleburghardt merged 9 commits intodevelopfrom
oleburghardt merged 9 commits intodevelopfrom
Conversation
oleburghardt
commented
Mar 21, 2025
pcarruscag
reviewed
Mar 21, 2025
pcarruscag
approved these changes
Mar 22, 2025
Member
|
@oleburghardt if everything is addressed can you resolve the conversations and merge please? |
Contributor
Author
Sure. CodeFactor is complaining about CSolver.hpp (complex code) which I've touched in a commit but which eventually remains unchanged. Forgot to ask during last dev meeting how we should handle it? |
Member
|
You can ignore that warning, It doesn't say what to do so we can't do anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This contributes two algorithmic-differentiation-based fixes;
SetRoe_Dissipation_FD. This may change derivatives as the current recording of this function is likely to be wrong ifPREACC = YES.muT(eddy viscosity) as input/output to the recording of RANS solvers. Since both muT and conservative variables go "on the same level" into the flow solver'sPreprocessing(i.e. we cannot think of muT as a derived value from the conservative ones), this should be reflected in the recording. (Also, the debug mode developed in Tape recording debug mode #2442 will complain otherwise ;-)).This change does not affect derivative values – especially it does nothing about the circumstance that Preprocessing is based on an initial value of muT, whereas the flow solvers depend on an updated one – but it may clarify things and remove a source of future problems.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.