Fix #2464: Removed restart check from spark initiation#2487
Merged
EvertBunschoten merged 1 commit intodevelopfrom Apr 10, 2025
Merged
Fix #2464: Removed restart check from spark initiation#2487EvertBunschoten merged 1 commit intodevelopfrom
EvertBunschoten merged 1 commit intodevelopfrom
Conversation
Contributor
|
Do we give a clear message when starting, that ignition is activated? Or maybe at the moment/iteration nr that we ignite we can give a message that we ignite. Just to make it clearly visible to the user. |
Member
Author
Right before starting the solver, a message is displayed saying that the solution is initiated with an artificial spark. It doesn't currently give a message when ignition takes place. |
raghava-davuluri
pushed a commit
to hypersonic-lab/SU2
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The spark initiation method for the flamelet solver was automatically disabled for restarts. Now it's enabled.
Related Work
Fix for issue #2464
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.