Camberline Hicks-Henne Parameterization as design feature#2538
Camberline Hicks-Henne Parameterization as design feature#2538pcarruscag merged 6 commits intosu2code:developfrom
Conversation
…hickness distribution is kept accoring to provided reference geometry.
pcarruscag
left a comment
There was a problem hiding this comment.
Thank you, can you add an example and regression test, maybe a version or a modification of one of the cases in TestCases/deformation
|
The failing of CodeFactor I feel is irrelevant, I tried copying the previous regression test syntax (white-space etc.), which is now producing the fail. For the regression test, I do not quite understand what exactly I should test. When I run the test myself and inspect the deformed mesh, there is a slight bump at the trailing edge (expected behavior for the design definition). I currently have the values set simply from manually running SU2_DEF and inserting the the residual value after 10 iterations as reference. I used the triangular NACA0012 mesh from the Quickstart for the test. |
pcarruscag
left a comment
There was a problem hiding this comment.
Good to go after addressing the comments 👍
Proposed Changes
I added a purely camberline driven parameterization to the design features.
Starting of from some reference airfoil geometry the thickness is fixed. The camberline is parameterized via hicks-henne bump functions.
I tested this with two NACA configurations (one with blunt trailing edge), I did not add these files due to the file size of the meshes.
Related Work
X
Reasoning
It presents a simplified design feature to test optimization methods. This is not intended as serious design feature!
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.