Common: fix missing <cstdint> include in CPrimalGrid.hpp; drop duplicate <limits>#2629
Merged
bigfooted merged 2 commits intosu2code:developfrom Nov 25, 2025
Merged
Conversation
…mits> This header declares PeriodIndexNeighbors as int8_t but relied on indirect includes for the type. Add an explicit #include <cstdint> to ensure portability across compilers and platforms (MSVC/Clang/GCC), and deduplicate a repeated <limits> include. No functional/runtime changes; this is a safe, hygiene-only fix that reduces the risk of build failures in strict toolchains and keeps the header self-contained. - Touches: Common/include/geometry/primal_grid/CPrimalGrid.hpp - Behavior change: none - Risk: low; header-only; does not affect algorithms, IO, or numerics Signed-off-by: Shubham shukla <shubhushukl586@gmail.com>
Author
|
/label changelog:fix |
pcarruscag
approved these changes
Nov 24, 2025
Contributor
|
@shbhmexe thanks for the fix! |
Author
Will it be merged after this? I hope it gets merged. Thanks for the approval! |
Author
|
Thanks @bigfooted sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds an explicit
#include <cstdint>toCPrimalGrid.hppto match the header’s use ofint8_tforPeriodIndexNeighbors. It also removes a duplicated#include <limits>.Rationale:
int8_tis always defined without depending on indirect includes.Related Work
None. This is a minimal maintenance fix isolated to a single header.
PR Checklist
pre-commit run --allto format old commits.Impact