Regularize matrices to fix FGMRES orthogonalization error#2651
Merged
pcarruscag merged 17 commits intodevelopfrom Dec 25, 2025
Merged
Regularize matrices to fix FGMRES orthogonalization error#2651pcarruscag merged 17 commits intodevelopfrom
pcarruscag merged 17 commits intodevelopfrom
Conversation
bigfooted
commented
Dec 19, 2025
bigfooted
commented
Dec 19, 2025
pcarruscag
reviewed
Dec 22, 2025
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Contributor
Author
|
Thanks, Pedro, I've introduced a helper function. |
pcarruscag
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes FGMRES orthogonalization failed errors in the flat plate and the naca0012 testcase (for me).
These can sometimes occur under certain conditions, as a once in a simulation event. When you regularize, the solver simply continues as if nothing ever happened. If there is more going on, this fix will not save your simulation.
pre-commit run --allto format old commits.