Fix: Prevent zero-division in Cp calculation for zero free-stream velocity#2666
Merged
pcarruscag merged 1 commit intosu2code:developfrom Dec 31, 2025
Merged
Conversation
4b74ccb to
33397a6
Compare
Member
|
Logic for this should be handled in |
33397a6 to
ce1d582
Compare
Contributor
Author
|
Done. I have moved the safety logic into |
Member
|
Add the required label to the PR and use the constant EPS instead of hardcoded value |
Member
|
open future PRs to develop instead of master |
ce1d582 to
cb8c34d
Compare
Contributor
Author
|
Thanks for the review. I have switched the logic to use I don't have permission to add labels to the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Pressure Coefficient (
Cp) calculation currently divides byReferenceDynamicPressurewithout checking if it is zero.This causes
NaNvalues or crashes when:Solution
Added a safety check for
GetReferenceDynamicPressure()in:CFlowCompOutput.cpp(Compressible)CFlowIncOutput.cpp(Incompressible)CNEMOCompOutput.cpp(NEMO / Hypersonic)If the dynamic pressure is effectively zero (
abs < 1e-10), the Cp output defaults to0.0instead of performing the division.