Streamwise periodicity for incompressible flow#773

TobiKattmann · 2019-08-26T09:01:39Z

Hi,

this PR adds streamwise periodic flow (incl energy eq) for the incompressible solver. For a more detailed information please see the website additions including a tutorial and theory section.

~half of the lines is .cfg's as those CHT setups require a bit more real estate. So the actual code is not too long.

Here a squash merge could be done as it merged develop quite a few times and has a bunch of 'small fix' commits. But to my knowledge that is not really necessary as.

I am ready to pass on the red lantern to someone else 🐌

Related Work

This work builds directly on #652 of @economon

PR Checklist

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.

…treamwise Conflicts: SU2_CFD/include/solver_structure.hpp SU2_CFD/include/variables/CVariable.hpp SU2_CFD/src/solver_direct_mean_inc.cpp

…treamwise

…treamwise Conflicts: SU2_CFD/src/output_structure.cpp

…treamwise

…treamwise Conflicts: SU2_CFD/src/numerics_direct_mean_inc.cpp

…treamwise

…treamwise Conflicts: Common/include/config_structure.hpp

…treamwise Conflicts: .travis.yml SU2_CFD/include/variables/CIncEulerVariable.hpp SU2_CFD/src/output/output_structure_legacy.cpp SU2_CFD/src/solver_direct_mean_inc.cpp

…treamwise Conflicts: .travis.yml

…treamwise Conflicts: Common/src/config_structure.cpp SU2_CFD/include/variables/CEulerVariable.hpp SU2_CFD/src/output/output_structure_legacy.cpp SU2_CFD/src/solver_direct_mean_inc.cpp SU2_CFD/src/variables/CIncEulerVariable.cpp TestCases/serial_regression.py

…treamwise

…odic_streamwise

…treamwise

…iodic_streamwise Conflicts: SU2_CFD/src/output/CFlowIncOutput.cpp SU2_CFD/src/solver_adjoint_discrete.cpp SU2_CFD/src/solver_structure.cpp

TobiKattmann · 2021-02-26T22:46:42Z

I guess one can ignore the CodeFactor complaints here as it just gives a vague complex code without any further line information error for CIncEulerSolver.cpp (which I could understand to some degree) and CSolver.hpp (which I dont understand at all).

Common/src/geometry/CPhysicalGeometry.cpp

SU2_CFD/include/numerics/flow/flow_sources.hpp

Common/src/geometry/CPhysicalGeometry.cpp

SU2_CFD/include/variables/CVariable.hpp

pcarruscag

Alright I think I covered everything.
World class documented code 👍
Loads of comments on this second pass, but they are just small re-arrangements to encapsulate the feature a bit better in terms of code, and in terms of side effects when not using it.

Common/include/CConfig.hpp

Common/src/geometry/CPhysicalGeometry.cpp

SU2_CFD/include/solvers/CSolver.hpp

SU2_CFD/src/output/COutput.cpp

SU2_CFD/src/solvers/CIncEulerSolver.cpp

SU2_CFD/src/solvers/CIncNSSolver.cpp

pcarruscag · 2021-02-27T10:17:06Z

SU2_CFD/src/numerics/flow/flow_sources.cpp

-  residual[nDim] = Volume * U_i[0] * STANDARD_GRAVITY;
+  residual[nDim] = Volume * U_i[0] * STANDARD_GRAVITY / Force_Ref;


Looks like a bug fix 👍

Common/include/CConfig.hpp

pcarruscag · 2021-02-27T10:32:09Z

No need to squash, the testcases repo is actually a bit messed up ATM because of that (oooops)

TobiKattmann · 2021-02-26T22:53:14Z

Common/include/CConfig.hpp

  unsigned short Geo_Description;     /*!< \brief Description of the geometry. */
  unsigned short Mesh_FileFormat;     /*!< \brief Mesh input format. */
  unsigned short Tab_FileFormat;      /*!< \brief Format of the output files. */
+  unsigned short output_precision;    /*!< \brief <ofstream>.precision(value) for SU2_DOT and HISTORY output */


There is possibly other locations (edit: beyond history and SU2_DOT) where one can plug this, but it is a start for gradient validation

SU2_CFD/include/solvers/CIncEulerSolver.hpp

…treamwise

pcarruscag · 2021-03-02T09:25:02Z

Common/src/geometry/CPhysicalGeometry.cpp

+  /*-------------------------------------------------------------------------------------------*/
+
+  /*--- Initialize/Allocate variables. ---*/
+  su2double min_norm = numeric_limits<su2double>::max();


Ah! no way, they've defined numeric_limits for the AD types, those guys rock.

SU2_CFD/include/solvers/CIncEulerSolver.hpp

pcarruscag · 2021-03-02T09:31:47Z

SU2_CFD/src/variables/CIncEulerVariable.cpp

-  /*--- Incompressible flow, gradients primitive variables nDim+4, (P, vx, vy, vz, T, rho, beta) ---*/
+  /*--- Incompressible flow, gradients primitive variables nDim+6, (P, vx, vy, vz, T, rho, beta, lamMu, EddyMu) ---*/


insert emoji with monocle

🧐 there you go

Where the heck do you get them from?

:monocle_face

most of the time I just put the : and type want I want to have (crazy, right :) ) those github emoji cheatsheets are often incomplete

🤦 here I was just trying to scroll down after typing :

TobiKattmann · 2021-03-02T09:34:37Z

Thanks a lot on the comments so far @pcarruscag . Helps quite a bit 👍
I think I addressed all your comments by now (using AuxVarGrad, a bunch of openMP instructions, overhauling the FindUnique_RefNode func, making a struct for the streamwise periodic values and using that in Numerics and the solver, not using config as a solver var container, and some other things )
Feel encouraged to comment/request-changes on more things.

pcarruscag

I would not have written / documented / tested better myself.
I'll aprove it again for good measure.

pcarruscag · 2021-03-02T15:08:58Z

All done? Is CodeFactor not letting you click the magic button?

TobiKattmann · 2021-03-02T15:52:55Z

There we go :)
The website stuff is no merged as well, so that can go live with the next master release.
Thanks again.

pr-triage bot added the PR: draft label Aug 26, 2019

TobiKattmann added 29 commits August 28, 2019 14:43

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

b36f751

…treamwise Conflicts: SU2_CFD/include/solver_structure.hpp SU2_CFD/include/variables/CVariable.hpp SU2_CFD/src/solver_direct_mean_inc.cpp

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

5ab6db6

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

ecc0b41

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

2a0b653

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

33e63ba

…treamwise Conflicts: SU2_CFD/src/output_structure.cpp

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

5d2f146

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

56380be

…treamwise Conflicts: SU2_CFD/src/numerics_direct_mean_inc.cpp

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

e11fa14

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

8e23deb

…treamwise Conflicts: Common/include/config_structure.hpp

Remove double config_structure function.

40066c1

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

ed810a4

…treamwise Conflicts: .travis.yml SU2_CFD/include/variables/CIncEulerVariable.hpp SU2_CFD/src/output/output_structure_legacy.cpp SU2_CFD/src/solver_direct_mean_inc.cpp

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

6481dfa

…treamwise Conflicts: .travis.yml

Adapting Reg.tests to new cfg names.

3a913c9

PR773 Adapting own Testcases to new output structure.

821f3b0

Fix compiler warnings. Add recovered values to new output.

c6789e3

Small change for non-periodic temperature.

fe564a9

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

12789bc

…treamwise

Delete unnecessary lines.

ab8cafb

Merge remote-tracking branch 'origin/various_fixes' into feature_peri…

c013e40

…odic_streamwise

Merge remote-tracking branch 'origin/various_fixes' into feature_peri…

239ebb2

…odic_streamwise

Merge remote-tracking branch 'origin/various_fixes' into feature_peri…

4239e87

…odic_streamwise

Added outlet heat sink for streamwise periodic flow.

5b4fe3e

Merge remote-tracking branch 'origin/various_fixes' into feature_peri…

47df471

…odic_streamwise

Merge remote-tracking branch 'origin/various_fixes' into feature_peri…

450d2bf

…odic_streamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

af9b2b0

…treamwise

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

31d5847

…treamwise

Added avg Temp obj func to primal incomp.

b9d48f7

Merge remote-tracking branch 'origin/feature_nlctrl' into feature_per…

a757f4e

…iodic_streamwise Conflicts: SU2_CFD/src/output/CFlowIncOutput.cpp SU2_CFD/src/solver_adjoint_discrete.cpp SU2_CFD/src/solver_structure.cpp

TobiKattmann changed the title ~~[WIP] Streamwise periodicity for incompressible flow~~ Streamwise periodicity for incompressible flow Feb 26, 2021

pr-triage bot added the PR: unreviewed label Feb 26, 2021

pcarruscag reviewed Feb 26, 2021

View reviewed changes

pcarruscag reviewed Feb 27, 2021

View reviewed changes

TobiKattmann commented Feb 27, 2021

View reviewed changes

Address PR comments. Part 1.

f0e887f

pcarruscag reviewed Feb 28, 2021

View reviewed changes

SU2_CFD/include/solvers/CIncEulerSolver.hpp Outdated Show resolved Hide resolved

TobiKattmann added 5 commits March 1, 2021 10:27

Merge remote-tracking branch 'origin/develop' into feature_periodic_s…

234fbd1

…treamwise

Adress PR comments. Part 2.

55df581

Resolve warning.

03d11b4

Put streamwise periodic solver vars in struct.

2f2e6f2

Compute mu_t grad via AuxVar.

fe7b0de

pcarruscag approved these changes Mar 2, 2021

View reviewed changes

Move GetStreamwisePerProp from Euler to NS solver.

8e7e567

TobiKattmann merged commit fa4e6e4 into develop Mar 2, 2021

TobiKattmann deleted the feature_periodic_streamwise branch March 2, 2021 15:48

pr-triage bot added PR: merged and removed PR: unreviewed labels Mar 2, 2021

TobiKattmann mentioned this pull request Mar 2, 2021

Add streamwise periodic tutorial and theory. su2code/su2code.github.io#53

Merged

TobiKattmann mentioned this pull request Mar 22, 2021

SU2 freezes for a case with exactly 4 cores #1241

Closed

This was referenced Jul 15, 2021

Another charge against pointer to pointer #1312

Merged

Fix equivalent area calculation #1329

Merged

TobiKattmann mentioned this pull request Jan 25, 2022

Streamwise Periodic restarts using flow.meta + Multizone PerSurface output #1527

Merged

5 tasks

TobiKattmann mentioned this pull request Feb 4, 2022

Fix adjoint for streamwise periodic massflow + General handling of adjoints of additional solution variables #1536

Merged

5 tasks

		residual[nDim] = Volume * U_i[0] * STANDARD_GRAVITY;
		residual[nDim] = Volume * U_i[0] * STANDARD_GRAVITY / Force_Ref;

		/--- Incompressible flow, gradients primitive variables nDim+4, (P, vx, vy, vz, T, rho, beta) ---/
		/--- Incompressible flow, gradients primitive variables nDim+6, (P, vx, vy, vz, T, rho, beta, lamMu, EddyMu) ---/

Conversation

TobiKattmann commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Work

PR Checklist

Uh oh!

TobiKattmann commented Feb 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pcarruscag commented Feb 27, 2021

Uh oh!

TobiKattmann Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TobiKattmann commented Mar 2, 2021

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

pcarruscag commented Mar 2, 2021

Uh oh!

TobiKattmann commented Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TobiKattmann commented Aug 26, 2019 •

edited

Loading

TobiKattmann Feb 26, 2021 •

edited

Loading