Skip to content

Conversation

@1Luc1
Copy link
Contributor

@1Luc1 1Luc1 commented May 23, 2025

Add a .env flag PUBLIC_CALENDAR_ENABLED which will show or hide the public selection for calendar. Related to PR #105.

@tchapi tchapi added the enhancement New feature or request label May 27, 2025
@1Luc1
Copy link
Contributor Author

1Luc1 commented May 28, 2025

@tchapi for the PHPUnit test to run correctly the public_calendar_enabled options has to be set. Has to be there an entry within .env.test with PUBLIC_CALENDAR_ENABLED=false so it does pass?

Copy link
Owner

@tchapi tchapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏🏼

We also need to make sure that calendars are not public when the option is set to False, which means modifying the PublicAwareDAVACLPlugin acls so that it honours the env var:

if ($calendar && $calendar->isPublic() && $public_calendar_enabled) {
// ...
}

@tchapi tchapi merged commit 091ccb4 into tchapi:main Jun 12, 2025
3 checks passed
@tchapi
Copy link
Owner

tchapi commented Jun 12, 2025

Note: I renamed it to PUBLIC_CALENDARS_ENABLED (with an S)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants