Skip to content

Validate reassign user in user delete command #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 3 commits into from
Mar 5, 2024
Merged

Validate reassign user in user delete command #482

danielbachhuber merged 3 commits into from
Mar 5, 2024

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 29, 2024

Fixes #461

  • This will perform sanity check for reassign value whether user is valid or not
  • Asks for confirmation if not valid

@ernilambar ernilambar requested a review from a team as a code owner February 29, 2024 05:57
@swissspidy
Copy link
Member

swissspidy commented Feb 29, 2024

Can we add tests for this?

@ernilambar
Copy link
Member Author

ernilambar commented Mar 1, 2024

Can we add tests for this?

@swissspidy I could not find a way to add feature test for this because behat test pauses due to WP_CLI::confirm() here.

danielbachhuber
danielbachhuber requested changes Mar 1, 2024
View reviewed changes
danielbachhuber
danielbachhuber reviewed Mar 5, 2024
View reviewed changes
@danielbachhuber danielbachhuber added command:user Related to 'user' command command:user-delete Related to 'user delete' command labels Mar 5, 2024
@danielbachhuber danielbachhuber added this to the 2.6.3 milestone Mar 5, 2024
@danielbachhuber danielbachhuber self-requested a review March 5, 2024 03:05
@danielbachhuber
Copy link
Member

danielbachhuber commented Mar 5, 2024

Great work on this PR, @ernilambar !

@danielbachhuber danielbachhuber merged commit 1ab4ad0 into wp-cli:main Mar 5, 2024
@ernilambar ernilambar deleted the 461-reassign-invalid-user branch March 5, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

command:user Related to 'user' command command:user-delete Related to 'user delete' command

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

Reassigning posts while deleting a user can result in lost posts if the target user does not exist

3 participants

@ernilambar @swissspidy @danielbachhuber