Fix a Wayland-related graphic bug for the status bar#46466
Fix a Wayland-related graphic bug for the status bar#46466probably-neb merged 2 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @pauldipietro on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
changed the title
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
| // Running on Wayland and using some scaling levels other than 100% causes a | ||
| // 1px gap above the status bar; adding a margin avoids this. |
There was a problem hiding this comment.
This seems like a quite hacky solution. Are we sure there isn't something better we could be doing to fix this? Are we sure it is Wayland specific?
some scaling levels other than 100%
The code seems to activate this for all scaling levels other than 1.0. Are we sure this is an issue at every scaling factor other than 1.0?
There was a problem hiding this comment.
I'm not the person who wrote the surrounding implementation, so no, I don't know if there's something somewhere else in the code base that could provide a cleaner fix, but my presumption has been that it's something upstream unless if there's a specific handler somewhere for Wayland rendering. As I stated on the original report, I tried it against both X11 and Wayland and didn't notice the issue on the former when scaling to different values.
As to whether we be sure that it's an issue at every scaling factor? Sure, if we test it manually against every single value. I shared screenshots of some common ones that could be set as a default by Plasma based on the monitor size. If you want to go more granular, you could also test it against thirds e.g. 1.33x or 1.66x, but I don't think there's any realistic scenario where a user will do anything beyond that.
To be candid I've more or less moved on from this PR given how long it's been open, so I'll leave it to your judgement as to whether or not you want to do anything with it.
There was a problem hiding this comment.
Ah ok, I clearly forgot to look at the issue when reviewing the PR. Thanks for the explanation and sorry about the long time to review!
Going to merge this
…46008) Release Notes: - Address a scenario where scaling in Wayland can cause a 1px gap above the status bar
probably-neb
force-pushed
the
fix-wayland-status-bar-gap
branch
from
fd49ca9 to
0436ed2
Compare
3 participants
Release Notes:
Closes #46008