Fix config file watch task leak#47246
Merged
probably-neb merged 1 commit intomainfrom Jan 20, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
probably-neb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-Up-For: #47243
Previously, we would detach tasks spawned to watch config files. However, the task blocked on receiving a file event before checking if the receiver for the updates channel was dropped, causing the task to never exit. The fix here was to return the task explicitly, so that it can be dropped instead of calling
.detach()on it. There is definitely a way toselect!between the receiver being dropped and the next file system event, but I couldn't figure it out in a reasonable amount of time and decided it wasn't worth it.Release Notes: