image_viewer: Add pinch event support#47351
Conversation
- Add platform support for pinch gestures: - macOS: NSEventType::NSEventTypeMagnify - Wayland: zwp_pointer_gesture_pinch_v1 protocol
cla-bot
Bot
added
the
cla-signed
MrSubidubi
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
agu-z
left a comment
agu-z
left a comment
There was a problem hiding this comment.
@MostlyKIGuess Thank you for your contribution. This is working well in my testing.
Before merging, I’d like to change the new GPUI methods to use [cfg(any(target_os = "linux", target_os = "macos"))] so consumers of the API are aware that this event isn’t available on Windows.
In the doc comments, we should also clarify that the event only works on macOS and Wayland, and explain how Windows simulates scroll wheel + Ctrl events on pinch.
In the future we may want to handle this complexity at the GPUI level, but I don’t think it’s a blocker as long as the API doesn’t suggest it should work when it won’t.
|
@MrSubidubi Sorry for the tag, is there anything that should be done here? |
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Yes - I should hit merge.
Thank you!
This change implements pinch / magnification gesture handling. This uses the following wayland [protocol](https://wayland.app/protocols/pointer-gestures-unstable-v1). And the following [API](https://developer.apple.com/documentation/appkit/nsevent/magnification) for mac. - Original: gpui-ce/gpui-ce#11 Release Notes: - Zooming works with pinching in and out inside Image Viewer
6 participants
This change implements pinch / magnification gesture handling.
This uses the following wayland protocol. And the following API for mac.
Release Notes: