settings: Remove settings field from HTTP context_servers#48003
Merged
settings: Remove settings field from HTTP context_servers#48003
settings field from HTTP context_servers#48003Conversation
HTTP context servers don’t support the settings field, so remove it during migration to avoid confusion. Other context server types are unaffected.
cla-bot
Bot
added
the
cla-signed
Contributor
|
I guess this needs a rebase, would be nice if it can get shipped soon. |
Member
Author
|
Yeah I just haven’t gotten the chance to rebase the changes and get this merged. Thanks for the nudge @dastrobu. |
bennetbo
approved these changes
Apr 15, 2026
zed-zippy
Bot
added
the
PR state:needs review
bennetbo
added a commit
that referenced
this pull request
Apr 15, 2026
5 tasks
MrSubidubi
removed
the
PR state:needs review
bennetbo
added a commit
that referenced
this pull request
Apr 15, 2026
bennetbo
added a commit
that referenced
this pull request
Apr 15, 2026
This is a follow up to #48003, instead of removing the settings key in a new migration, we can prevent the existing one from adding settings in the first place. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
G36maid
pushed a commit
to G36maid/zed
that referenced
this pull request
Apr 29, 2026
…dustries#48003) HTTP context servers don’t support the settings field, so remove it during migration to avoid confusion. Other context server types are unaffected. Closes zed-industries#44786. https://github.com/user-attachments/assets/4cabf405-c9e7-4d6e-a43d-f642fc4771e0 Release Notes: - Removed deprecated key from HTTP `context_servers` --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
G36maid
pushed a commit
to G36maid/zed
that referenced
this pull request
Apr 29, 2026
This is a follow up to zed-industries#48003, instead of removing the settings key in a new migration, we can prevent the existing one from adding settings in the first place. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP context servers don’t support the settings field, so remove it during migration to avoid confusion. Other context server types are unaffected.
Closes #44786.
zed.settings.json.2026-01-30.05.24.07.mp4
Release Notes:
context_servers