workspace: Stop middle-click event propagation on tab close#49305
Merged
probably-neb merged 1 commit intozed-industries:mainfrom Mar 30, 2026
Merged
Conversation
On Linux, middle-clicking a tab to close it also triggered a paste of the primary selection into the editor behind it, because the event bubbled to the editor's mouse_up handler. Add cx.stop_propagation() after closing the tab, matching the pattern already used by the editor's own middle-click handler in element.rs. Closes #47381
|
We require contributors to sign our Contributor License Agreement, and we don't have @ArthurDEV44 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Collaborator
|
Nice catch, thanks! |
Collaborator
|
@zed-zippy approved |
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…stries#49305) ## Summary - On Linux, middle-clicking a tab to close it also triggered a paste of the primary selection into the editor behind it, because the event bubbled to the editor's `mouse_up()` handler - Added `cx.stop_propagation()` in the `on_aux_click` handler in `pane.rs` after closing the tab, matching the pattern already used by the editor's own middle-click handler in `element.rs:1037` Closes zed-industries#47381 ## Test plan - [x] `cargo test -p workspace` passes (124 tests, 0 failures) - [x] Select text in editor (filling primary selection), middle-click a tab to close it → tab closes, no paste in the editor behind - [x] Middle-click inside the editor area → still pastes from primary selection as expected Release Notes: - Fixed middle-click on a tab to close it also pasting into the editor on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mouse_up()handlercx.stop_propagation()in theon_aux_clickhandler inpane.rsafter closing the tab, matching the pattern already used by the editor's own middle-click handler inelement.rs:1037Closes #47381
Test plan
cargo test -p workspacepasses (124 tests, 0 failures)Release Notes: