Prevent underline and strikethrough artifacts on final glyph in text runs#50934
Merged
smitbarmase merged 2 commits intozed-industries:mainfrom Apr 8, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
Hi @dinocosta. Can you please review this as well? |
Signed-off-by: Pratik Karki <[email protected]>
smitbarmase
force-pushed
the
markdown-preview-underline-bug-fix
branch
from
61eca52 to
3440b80
Compare
ChristopherBiscardi
approved these changes
Apr 8, 2026
Caio-Ze
pushed a commit
to Caio-Ze/postprod-ide
that referenced
this pull request
Apr 8, 2026
… text runs (zed-industries#50934) Closes zed-industries#50587 Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed issue that showed underline and strikethrough when markdown preview screen was scaled to a smaller size Previously: <img width="741" height="457" alt="image" src="https://github.com/user-attachments/assets/f127cf44-c679-4140-b246-e0756c9fca32" /> Now: <img width="742" height="592" alt="image" src="https://github.com/user-attachments/assets/a29fdc24-cac0-438f-8538-4e85c4df995a" /> --------- Signed-off-by: Pratik Karki <[email protected]> Co-authored-by: Smit Barmase <[email protected]>
AzureZee
added a commit
to AzureZee/gpuix
that referenced
this pull request
Apr 9, 2026
AzureZee
added a commit
to AzureZee/gpuix
that referenced
this pull request
Apr 9, 2026
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
… text runs (zed-industries#50934) Closes zed-industries#50587 Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed issue that showed underline and strikethrough when markdown preview screen was scaled to a smaller size Previously: <img width="741" height="457" alt="image" src="https://github.com/user-attachments/assets/f127cf44-c679-4140-b246-e0756c9fca32" /> Now: <img width="742" height="592" alt="image" src="https://github.com/user-attachments/assets/a29fdc24-cac0-438f-8538-4e85c4df995a" /> --------- Signed-off-by: Pratik Karki <[email protected]> Co-authored-by: Smit Barmase <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50587
Before you mark this PR as ready for review, make sure that you have:
Release Notes:
Previously:
Now: