Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
kubkon
added
run-bundling
kubkon
force-pushed
the
kubkon/push-qukyoxlq
branch
2 times, most recently
from
4c1d277 to
8de82d9
Compare
kubkon
force-pushed
the
kubkon/push-qukyoxlq
branch
from
8de82d9 to
1ee1319
Compare
kubkon
force-pushed
the
kubkon/push-qukyoxlq
branch
7 times, most recently
from
c47c268 to
6b24880
Compare
| # We need lld to link libwebrtc.a successfully on aarch64-linux. | ||
| # NOTE: Since RUSTFLAGS env var overrides all .cargo/config.toml rustflags | ||
| # (see https://github.com/rust-lang/cargo/issues/5376), the | ||
| # [target.aarch64-unknown-linux-gnu] section in config.toml has no effect here. | ||
| if [[ "$(uname -m)" == "aarch64" ]]; then | ||
| export RUSTFLAGS="${RUSTFLAGS:-} -C link-arg=-fuse-ld=lld -C link-args=-Wl,--disable-new-dtags,-rpath,\$ORIGIN/../lib" | ||
| else | ||
| export RUSTFLAGS="${RUSTFLAGS:-} -C link-args=-Wl,--disable-new-dtags,-rpath,\$ORIGIN/../lib" | ||
| fi |
There was a problem hiding this comment.
@kubkon did you try to run this binary on aarch64 linux?
I consistently segfault every time when I run libexec/zed-editor
from codex:
What I found from the binaries:
- The known-good artifact you gave me runs normally under qemu-aarch64.
- The broken current nightly crashes in __libc_csu_init because 7 constructor pointers in .init_array stay null.
- Good binary:
- no .crel.* sections
- .init_array has 1374 entries
- all 1374 have normal R_AARCH64_RELATIVE coverage
- Broken binary:
- has new .crel.* sections, including .crel.init_array
- .init_array has 1383 entries
- only 1376 are covered by normal dynamic RELA relocations
- the missing 7 line up with the .crel.init_array payload
There was a problem hiding this comment.
I haven't but thanks for letting me know. I will take a look!
There was a problem hiding this comment.
@maan2003 I am working on a fix - it's pretty simple conceptually. Since CREL is an optimisation of sorts, let's disable it when building libwebrtc.a. I am halfway there - generating the static lib now, will then update our fork of livekit and Zed, and provide you with a link to test nightly build that I would very much appreciate if you could test on your end.
There was a problem hiding this comment.
awesome, I am happy to test. just ping me.
There was a problem hiding this comment.
@maan2003 can you try this build https://github.com/zed-industries/zed/actions/runs/23207020667/artifacts/5970355080?
There was a problem hiding this comment.
Perfect, thanks for checking!
Closes zed-industries#51339 This should address issues with too new libstdc++.so on older/more conservative distros such as RHEL9. Release Notes: - Relaxed requirement for libstdc++.so available on Linux distros.
2 participants
Closes #51339
This should address issues with too new libstdc++.so on older/more conservative distros such as RHEL9.
Release Notes: