Skip to content

markdown: Fix block quote continuation highlighting#51465

Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom
polyesterswing:fix-markdown-blockquote
Mar 13, 2026
Merged

markdown: Fix block quote continuation highlighting#51465
MrSubidubi merged 1 commit intozed-industries:mainfrom
polyesterswing:fix-markdown-blockquote

Conversation

@polyesterswing
Copy link
Copy Markdown
Contributor

@polyesterswing polyesterswing commented Mar 13, 2026

There is no highlight for block quotes continued on multiple lines

Currently, the ">" on lines 2 and 3 are not highlighted in the same way as line 1
image

After this PR,
image

for this input

> abcd
>
> abcd

tree-sitter produces this

(document [0, 0] - [3, 0]
  (section [0, 0] - [3, 0]
    (block_quote [0, 0] - [3, 0]
      (block_quote_marker [0, 0] - [0, 2])
      (paragraph [0, 2] - [1, 1]
        (inline [0, 2] - [0, 6])
        (block_continuation [1, 0] - [1, 1]))
      (block_continuation [2, 0] - [2, 2])
      (paragraph [2, 2] - [3, 0]
        (inline [2, 2] - [2, 6])))))

the screenshots in #43043 also show this issue

Release Notes:

  • Fixed highlighting of block quotes continued over multiple lines in markdown files

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 13, 2026
@MrSubidubi MrSubidubi self-assigned this Mar 13, 2026
@MrSubidubi MrSubidubi changed the title Fix block quote highlighting in markdown files markdown: Fix block quote continuation highlighting Mar 13, 2026
@polyesterswing polyesterswing force-pushed the fix-markdown-blockquote branch from c31b8b0 to a1f618c Compare March 13, 2026 21:56
MrSubidubi
MrSubidubi approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@MrSubidubi MrSubidubi merged commit da8a7e8 into zed-industries:main Mar 13, 2026
29 checks passed
tommyming pushed a commit to tommyming/zed that referenced this pull request Mar 15, 2026
@polyesterswing @tommyming
markdown: Fix block quote continuation highlighting (zed-industries#5…
5ccd958 
…1465)

There is no highlight for block quotes continued on multiple lines

Currently, the ">" on lines 2 and 3 are not highlighted in the same way
as line 1
<img width="291" height="73" alt="image"
src="https://github.com/user-attachments/assets/7a2f2e25-6ee1-40a6-8833-f06ca7ee6ba9"
/>

After this PR,
<img width="249" height="75" alt="image"
src="https://github.com/user-attachments/assets/34a2971f-8061-4d92-ac45-a8043d5d0566"
/>


for this input
```md
> abcd
>
> abcd
```

tree-sitter produces this 
```
(document [0, 0] - [3, 0]
  (section [0, 0] - [3, 0]
    (block_quote [0, 0] - [3, 0]
      (block_quote_marker [0, 0] - [0, 2])
      (paragraph [0, 2] - [1, 1]
        (inline [0, 2] - [0, 6])
        (block_continuation [1, 0] - [1, 1]))
      (block_continuation [2, 0] - [2, 2])
      (paragraph [2, 2] - [3, 0]
        (inline [2, 2] - [2, 6])))))
```

the screenshots in zed-industries#43043 also show this issue

Release Notes:

- Fixed highlighting of block quotes continued over multiple lines in
markdown files
@zelenenka zelenenka added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 16, 2026
@esthertrapadoux esthertrapadoux moved this to Shipped by the Guild in Zed Guild - The Board Mar 25, 2026
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
@polyesterswing
markdown: Fix block quote continuation highlighting (zed-industries#5…
10c0a18 
…1465)

There is no highlight for block quotes continued on multiple lines

Currently, the ">" on lines 2 and 3 are not highlighted in the same way
as line 1
<img width="291" height="73" alt="image"
src="https://github.com/user-attachments/assets/7a2f2e25-6ee1-40a6-8833-f06ca7ee6ba9"
/>

After this PR,
<img width="249" height="75" alt="image"
src="https://github.com/user-attachments/assets/34a2971f-8061-4d92-ac45-a8043d5d0566"
/>


for this input
```md
> abcd
>
> abcd
```

tree-sitter produces this 
```
(document [0, 0] - [3, 0]
  (section [0, 0] - [3, 0]
    (block_quote [0, 0] - [3, 0]
      (block_quote_marker [0, 0] - [0, 2])
      (paragraph [0, 2] - [1, 1]
        (inline [0, 2] - [0, 6])
        (block_continuation [1, 0] - [1, 1]))
      (block_continuation [2, 0] - [2, 2])
      (paragraph [2, 2] - [3, 0]
        (inline [2, 2] - [2, 6])))))
```

the screenshots in zed-industries#43043 also show this issue

Release Notes:

- Fixed highlighting of block quotes continued over multiple lines in
markdown files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSubidubi MrSubidubi MrSubidubi approved these changes

Assignees

@MrSubidubi MrSubidubi

Labels

cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

Zed Guild - The Board
Status: Shipped by the Guild

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@polyesterswing @MrSubidubi @esthertrapadoux @zelenenka