workspace: Handle double-click on pinned tab row empty space

[mgabor3141]

When tab_bar.show_pinned_tabs_in_separate_row is enabled, double-clicking the empty space on the unpinned tab row creates a new tab, but double-clicking the empty space on the pinned tab row does nothing.

Add the same on_click double-click handler to the pinned tab bar drop target so both rows behave consistently.

Release Notes:

• Fixed double-clicking empty space in the pinned tab row not opening a new tab when show_pinned_tabs_in_separate_row is enabled.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mgabor3141.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[JosephTLyons]

Hey @mgabor3141, these changes are looking and feeling good, and they match what VS Code does when the double pinned tab bar setting is enabled. That being said, I'd like to pin down this behavior with a test, which would involve setting up the test to have the tab_bar.show_pinned_tabs_in_separate_row enabled, adding a pinned tab, locating the empty space in the pinned tab bar, doing a double click, and asserting a new empty tab is added to the non-pinned tab bar.

If you scan the tests in pane.rs, you should find examples for how to do most of that. These two tests will cover most of it.

• test_separate_pinned_row_has_right_border
• test_middle_click_pinned_tab_does_not_close

Once a test is in place, and this is rebased on main, I'm happy to merge it into the main. :)

[JosephTLyons]

I went ahead and added in a test so we could merge this in. Thanks @mgabor3141

[mgabor3141]

I went ahead and added in a test so we could merge this in. Thanks @mgabor3141

Thanks. I've been busy with other things so I couldn't get to this one. Thank you for taking it over the finish line.