terminal_element: Skip contrast adjustment for 24-bit color#52162
Merged
Veykril merged 1 commit intozed-industries:mainfrom Apr 20, 2026
Merged
Conversation
…ground Red and blue have inherently low perceptual luminance in APCA — pure default Lc 45 threshold. This caused ensure_minimum_contrast to lighten them, washing out the color to pink/lavender. When an application explicitly specifies an RGB value via ESC[38;2;R;G;Bm, that color should be rendered as-is. Named and indexed colors continue to be contrast-adjusted since they come from theme mappings
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
guild
zed-codeowner-coordinator
Bot
requested review from
a team,
Veykril and
cole-miller
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Red and blue have inherently low perceptual luminance in APCA — pure default Lc 45 threshold. This caused ensure_minimum_contrast to lighten them, washing out the color to pink/lavender.
When an application explicitly specifies an RGB value via ESC[38;2;R;G;Bm,
that color should be rendered as-is. Named and indexed colors continue to be contrast-adjusted since they come from theme mappings
zed-colors-before.webm
zed-colors-after.webm
Closes: #50396
Self-Review Checklist
Release Notes: