Skip to content

vim: Prevent flickering during movement actions#52270

Merged
cameron1024 merged 2 commits intozed-industries:mainfrom
feitreim:bugfix-vim-flickering
Apr 20, 2026
Merged

vim: Prevent flickering during movement actions#52270
cameron1024 merged 2 commits intozed-industries:mainfrom
feitreim:bugfix-vim-flickering

Conversation

@feitreim
Copy link
Copy Markdown
Contributor

Context

Closes #52202

Some actions we're unnecessarily delayed during execution by a yield_now().await call, causing flickering while moving around.

Video Before:

before.mov

Video After:

after.mov

How to Review

when we call the yield in workspace.rs

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • vim: fixed screen flickering during motions.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 23, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, cameron1024 and dinocosta and removed request for a team March 23, 2026 23:43
@zed-community-bot zed-community-bot Bot added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 23, 2026
@cameron1024
Copy link
Copy Markdown
Contributor

Thanks for looking into this 😁

@zed-industries/approved

@cameron1024 cameron1024 merged commit e18da9e into zed-industries:main Apr 20, 2026
31 checks passed
@babyccino
Copy link
Copy Markdown
Contributor

@feitreim absolute legend! I can update zed again 🙏

@feitreim feitreim deleted the bugfix-vim-flickering branch April 21, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

running two actions in keymap in editor causes screen to flicker

4 participants