go: Add semantic token rule for format string interpolations#52394
Merged
Veykril merged 1 commit intozed-industries:mainfrom Mar 25, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
Contributor
Author
Veykril
changed the title
zed-codeowner-coordinator
Bot
requested review from
a team,
rtfeldman and
smitbarmase
and removed request for
a team
zed-community-bot
Bot
added
the
first contribution
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…ustries#52394) ## Context Closes zed-industries#52391 gopls sends semantic tokens for format args with [format] modifier. Without a simple support for there is no special highlighting for format args like `%s`. Its a simple change inside `go/semantic_token_rules.json` that makes this a default behavior. Currently (on 0.229 preview): <img width="1136" height="675" alt="Screenshot 2026-03-25 at 11 34 57" src="https://github.com/user-attachments/assets/cd3d9a52-6740-47b5-8f05-02514cb4f9df" /> After fix: <img width="1136" height="675" alt="Screenshot 2026-03-25 at 11 58 37" src="https://github.com/user-attachments/assets/5ec4277b-39c1-4fe1-bed5-8a6fa63c18c9" /> ## Self-Review Checklist <!-- Check before requesting review: --> - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - gopls: Add semantic token rule for format string interpolations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #52391
gopls sends semantic tokens for format args with [format] modifier. Without a simple support for there is no special highlighting for format args like
%s. Its a simple change insidego/semantic_token_rules.jsonthat makes this a default behavior.Currently (on 0.229 preview):
After fix:
Self-Review Checklist
Release Notes: