editor: Cancel blame popover task when opening modal#52525
Merged
dinocosta merged 5 commits intozed-industries:mainfrom Apr 20, 2026
Merged
editor: Cancel blame popover task when opening modal#52525dinocosta merged 5 commits intozed-industries:mainfrom
dinocosta merged 5 commits intozed-industries:mainfrom
Conversation
cla-bot
Bot
added
the
cla-signed
github-actions
Bot
added
the
community champion
zed-codeowner-coordinator
Bot
requested review from
a team,
as-cii and
dinocosta
and removed request for
a team
* Update the `Editor::hide_blame_popover` method implementation to avoid spawning a task in the foreground executor in case the timeout is to be ignored, that way we're not only sure that the popover is dismissed immediatelly, as the foreground executor can be busy with a long-running non-async task that will make the dismissal end up being delayed, and we avoid the overhead of spawning the task. * Update the `Editor::hide_blame_popover` method's documentation. * Simplify the `test_hide_pending_blame_popover_when_modal_opens` test, as it appears it was only passing because of the change in `Editor::selections_did_change` and not actually because the modal was being opened .
smitbarmase
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that causes the inline blame popover to appear after opening a modal, if that modal is opened immediately after hovering over the blame annotation.
Before:
before.mov
After:
after.mov
Self-Review Checklist
Release Notes: