Skip to content

Ignore user config when checking remote git URL for dev extensions#52538

Merged
smitbarmase merged 2 commits intozed-industries:mainfrom
brandonchinn178:extension-git-url
Apr 3, 2026
Merged

Ignore user config when checking remote git URL for dev extensions#52538
smitbarmase merged 2 commits intozed-industries:mainfrom
brandonchinn178:extension-git-url

Conversation

@brandonchinn178
Copy link
Copy Markdown
Contributor

@brandonchinn178 brandonchinn178 commented Mar 26, 2026 •
edited
Loading

Context

Fixes #48163

Also update the logic from git remote -v + manually parse => git remote get-url origin

Not sure the best way to test this

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed rebuilding dev extensions when user git config contains url rewriting rules

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 26, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 26, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, MrSubidubi and smitbarmase and removed request for a team March 26, 2026 21:39
smitbarmase
smitbarmase requested changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a suggestion:

Comment thread crates/extension/src/extension_builder.rs
smitbarmase
smitbarmase approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@smitbarmase smitbarmase left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense. I think it wouldn't be the right approach for, say, fetch where user config like credential.helper or http.proxy will matter for us to preserve that, but in this case, it shouldn't harm.

@smitbarmase smitbarmase merged commit 0b984b5 into zed-industries:main Apr 3, 2026
44 checks passed
@brandonchinn178 brandonchinn178 deleted the extension-git-url branch April 3, 2026 23:55
rtfeldman pushed a commit that referenced this pull request Apr 4, 2026
@brandonchinn178 @rtfeldman
Ignore user config when checking remote git URL for dev extensions (#…
b246efd 
…52538)

## Context

Fixes #48163

Also update the logic from `git remote -v` + manually parse => `git
remote get-url origin`

Not sure the best way to test this

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fixed rebuilding dev extensions when user git config contains url
rewriting rules
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
@brandonchinn178
Ignore user config when checking remote git URL for dev extensions (z…
f671381 
…ed-industries#52538)

## Context

Fixes zed-industries#48163

Also update the logic from `git remote -v` + manually parse => `git
remote get-url origin`

Not sure the best way to test this

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fixed rebuilding dev extensions when user git config contains url
rewriting rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smitbarmase smitbarmase smitbarmase approved these changes

@MrSubidubi MrSubidubi Awaiting requested review from MrSubidubi MrSubidubi was automatically assigned from zed-industries/ecosystem-team

Assignees

@smitbarmase smitbarmase

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extension rebuild fails during development due to git URL redirect in gitconfig

2 participants

@brandonchinn178 @smitbarmase