Skip to content

editor: Prevent blame popover from appearing when cursor is on different pane#52603

Merged
cole-miller merged 1 commit intozed-industries:mainfrom
timvermeulen:prevent-blame-popover-different-pane
Apr 1, 2026
Merged

editor: Prevent blame popover from appearing when cursor is on different pane#52603
cole-miller merged 1 commit intozed-industries:mainfrom
timvermeulen:prevent-blame-popover-different-pane

Conversation

@timvermeulen
Copy link
Copy Markdown
Contributor

The blame popover shouldn't appear when the cursor hovers over the annotation but on a different pane.

Before:

before.mov

After:

after.mov

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed a bug that caused git blame annotations to be hoverable from a different pane.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 27, 2026
@github-actions github-actions Bot added the community champion Issues filed by our amazing community champions! 🫶 label Mar 27, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, Veykril and cole-miller and removed request for a team March 27, 2026 20:49
@cole-miller
Copy link
Copy Markdown
Member

Thanks!

@cole-miller cole-miller enabled auto-merge (squash) April 1, 2026 14:30
@cole-miller cole-miller merged commit 4a0c02b into zed-industries:main Apr 1, 2026
33 checks passed
@timvermeulen timvermeulen deleted the prevent-blame-popover-different-pane branch April 2, 2026 00:11
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label Apr 6, 2026
@cole-miller
Copy link
Copy Markdown
Member

@zed-industries/approved

@MrSubidubi MrSubidubi removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label Apr 7, 2026
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
…ent pane (zed-industries#52603)

The blame popover shouldn't appear when the cursor hovers over the
annotation but on a different pane.

Before:


https://github.com/user-attachments/assets/dbf6f7b5-e27f-495b-8d6f-fa75a4feee18

After:


https://github.com/user-attachments/assets/d5e186df-4ebf-4b4c-bb5f-4d9e7b0f62c7

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fixed a bug that caused git blame annotations to be hoverable from a
different pane.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants